Missing edge for multiple targets #8854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR fixes the "missing edge" error when using multiple targets. A change had to be made in
mutablebundleGraph
because the way the current default bundler handles multiple targets is by producing an intermediate graph for each target and then mutating the assetgraph x times.As a result, we attempted to add the same
bundleGroup
twice, which has an edge removal. We need to allow that edge to potentially already not exist.This also raises a follow up question, are we doing duplicate work in the bundler for multiple targets? If two targets shared a lot of the same assets, do we need to decorate those nodes more than once or not? (For now it seems okay but something to think about)
✔️ PR Todo