Wrong number of arguments in a call

[DimitriPapadopoulos]

Call to function scp_single with too few arguments; should be no fewer than 3.

Indeed the shape argument is missing:

ramp-workflow/rampwf/score_types/detection/util.py

Lines 214 to 216 in 7d07521

	for conf_threshold in conf_thresholds:
	y_pred_above_confidence = _filter_y_pred(y_pred, conf_threshold)
	ms.append(scp_single(y_true, y_pred_above_confidence))

See:
https://lgtm.com/projects/g/paris-saclay-cds/ramp-workflow/snapshot/97b80f6dbfaf877cc5d8f807d90fd2986978019e/files/rampwf/score_types/detection/util.py?sort=name&dir=ASC&mode=heatmap#x31a3fdb0293f3757:1

[DimitriPapadopoulos]

I see a more general issue with the shape argument in the call tree:

scp_single (y_true, y_pred, shape, minipatch=None)
└── circle_maps (y_true, y_pred, shape)
    ├── numpy.zeros (shape)
    └── project_circle (circle, image=None, shape=None, normalize=True, negative=False)

The shape argument of scp_single() is not optional:

ramp-workflow/rampwf/score_types/detection/scp.py

Line 52 in 7d07521

def scp_single(y_true, y_pred, shape, minipatch=None):

The shape argument of circle_maps() is not optional:

ramp-workflow/rampwf/score_types/detection/scp.py

Line 139 in 7d07521

def circle_maps(y_true, y_pred, shape):

but it is documented to be optional, without a clear default value (None?):

ramp-workflow/rampwf/score_types/detection/scp.py

Lines 153 to 154 in 7d07521

	shape : tuple of ints, optional
	shape of image

The shape argument of project_circle() is optional and its default value is None:

ramp-workflow/rampwf/score_types/detection/scp.py

Lines 93 to 94 in 7d07521

	def project_circle(circle, image=None, shape=None,
	normalize=True, negative=False):

Note that numpy.zeros(None) is valid and returns array(0.0). Is that what is expected when the shape argument of circle_maps() is None?

ramp-workflow/rampwf/score_types/detection/scp.py

Lines 161 to 162 in 7d07521

	map_true = np.zeros(shape)
	map_pred = np.zeros(shape)

[DimitriPapadopoulos]

So my questions are:

1. Should shape be an optional argument for scp_single() and circle_maps()? If so, the default value would be None.
2. Does project_circle() do the right thing when shape is None? I haven't looked into the function in enough detail to have an opinion (I could do that but I thought I would ask first).

[agramfort]

@rth @kegl @albertcthomas do you have time to look?

thx @DimitriPapadopoulos

[kegl]

Hm, this was done mostly by @jorisvandenbossche if I'm not mistaken. Are you guys @agramfort @DimitriPapadopoulos are planning to use this in an upcoming challenge? In this case I'd review the whole detection pipeline. I have no objection on PRs that fix this or anything else in detection (on the contrary, pls go ahead, thanks a lot!), it's well encapsulated within the RAMP detection framework and should not affect anything else.