Update solidity #11
Open
Update solidity #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Pull Request Test Coverage Report for Build 153
💛 - Coveralls |
tomusdrw
reviewed
Jun 20, 2018
| return 0; | ||
| } | ||
| return clientExists(_client) && | ||
| latestInTrack(_client, track(_client, _release)) == _release; |
There was a problem hiding this comment.
latestInTrack is external, are you sure we can call it from here?
There was a problem hiding this comment.
It's defined as external in the interface (it's mandatory) but it's overridden here as public. (Also these changes come from #10).
andresilva
force-pushed
the
andre/update-solidity
branch
from
01c3fbc
to
edc829e
Compare
kirushik
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #10.
Update solidity because of constructor bug in 0.4.22.