-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vector arguments #451
Conversation
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the problem for me, thanks!
I also really like the new UX for bytes, way more convenient for larger byte arrays. However, I have a nitpick. The bytes input can be an odd number of hex digits. Considering an input of 0xBBB
, it's not clear whether this will resolve to 0xBBB0
or 0x0BBB
which are not the same. I suggest to only allow an even number of bytes (or 0).
ideally we would have validation for these dynamic argument inputs but at the moment it's not possible. it needs a large refactoring. |
fixes #431
For case 2 we display a new input which accepts a hex representation of
Bytes
.I figure this is a bit better UX than working with decimal digits.
can you please test @xermicus?