Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

v7 release branch does't build #938

Closed
gilescope opened this issue Jan 31, 2022 · 5 comments · Fixed by #940
Closed

v7 release branch does't build #938

gilescope opened this issue Jan 31, 2022 · 5 comments · Fixed by #940
Labels
B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains.

Comments

@gilescope
Copy link
Contributor

gilescope commented Jan 31, 2022

While the 9.16 branch builds the v7 does not. ( https://github.com/paritytech/cumulus/runs/5006506401?check_suite_focus=true )

I think we can get past the first build failure by a change like

fn host_storage_root() -> Vec<u8> {
	vec[]
	with_externalities(|ext| ext.storage_root(StateVersion::V0))
}

in pallets/parachain-system/src/validate_block/implementation.rs

reverting b03e8bcf151bbf4c20a7d7faa782366fc3554d58 should fix this.

but then there seem to be some clap issues also:

error[E0277]: the trait bound `sc_cli::RunCmd: FromArgMatches` is not satisfied
   --> client/cli/src/lib.rs:126:9
    |
126 |     #[clap(flatten)]
    |            ^^^^^^^ the trait `FromArgMatches` is not implemented for `sc_cli::RunCmd`

(maybe the latest cut has brought in a new version of clap?)

UPDATE:
reverting
b03e8bcf151bbf4c20a7d7faa782366fc3554d58 ,
9c977d6
and fd14576 should fix the build. The latter two are reverted already in the cumulus 9.16 release branch, but not the first one - let me check if something was brought in to fix that.

I also think we need to include: 86f76c5 (as this was on the release branch of cumulus)

@gilescope
Copy link
Contributor Author

dep of #937

@gilescope
Copy link
Contributor Author

ah looks like master has gone from structopt to clap.

@gilescope
Copy link
Contributor Author

gilescope commented Jan 31, 2022

reverting #895 sorts out the clap issues. (I presume it is a companion to something that is not in 9.16 though need to confirm that) - I think we can cherry pick 5d7f6a9 to do this.

@gilescope
Copy link
Contributor Author

also if we cherry pick this commit: ec07b4e to revert #901 then we get something that builds again. Yay.

@hbulgarini hbulgarini linked a pull request Feb 1, 2022 that will close this issue
@hbulgarini hbulgarini added the T7-system_parachains This PR/Issue is related to System Parachains. label Feb 1, 2022
@hbulgarini hbulgarini added this to the statemint-v7.0.0 milestone Feb 1, 2022
@hbulgarini hbulgarini linked a pull request Feb 1, 2022 that will close this issue
@chevdor chevdor added the B0-silent Changes should not be mentioned in any release notes label Feb 1, 2022
@gilescope
Copy link
Contributor Author

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
3 participants