This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Flexibility in xcm-emulator methods #3037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystalin
approved these changes
Aug 21, 2023
librelois
approved these changes
Aug 21, 2023
Agusrodri
approved these changes
Aug 21, 2023
gilescope
reviewed
Aug 22, 2023
| @@ -76,6 +76,8 @@ pub use xcm::{ | |||
| }; | |||
| pub use xcm_executor::traits::ConvertLocation; | |||
|
|
|||
| pub type RuntimeAccountId<T> = <T as frame_system::Config>::AccountId; | |||
There was a problem hiding this comment.
Just wondering if we could call it AccountIdOf?
gilescope
added
B0-silent
This was referenced Sep 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the
accountIdtype from theaccountId32type and rather makes emulator methods depend on theaccountIdtype defined by the chain runtime in question. This is important if we want the emulator to stay compatible with chains that have 20 byte accounts like Moonbeam.The only method I did not change is
account_id_of, because it is tied tosr25519account generation. In any case this method is not that crucial because 20 byte account senders and receivers can be declared with theparameter_types!macro.Kusama address: HZetxGJ1k9kJdNwHFHUn3i2Xk11jqiX6kRG89BJZXcNAm8z