Moved constants from match to a separate constants
#1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
- Coverage 71.97% 71.95% -0.02%
==========================================
Files 187 187
Lines 5941 5945 +4
==========================================
+ Hits 4276 4278 +2
- Misses 1665 1667 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ascjones
approved these changes
Sep 28, 2022
|
We need to backport to the v3.x.x branch and make a release. |
agryaznov
added a commit
that referenced
this pull request
Oct 18, 2022
agryaznov
added a commit
that referenced
this pull request
Oct 20, 2022
* Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls (#1379) * first ver.: transfer_in api function implememted but we can't have it in on-chain env * transfer_in moved to test_api * doc + example updated * Update examples/contract-transfer/lib.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * use stmt moved to macro * docs and nitty gritties * moved the macro to the test mod * spell fix * next review round suggestions applied * Use four spaces for macro indentation Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Allow `pay_with_call` to take multiple arguments (#1401) * Moved constants from `match` to a separate constants (#1418) * fix tests Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Andrew Jones <ascjones@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #1417. It can be used to patch all old releases of ink!.
To reproduce the bug, you need to build any contract with the latest
+nightly. The proof that fix works below=)