Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify/Document Params parsing behavior #641

Open
tomusdrw opened this issue Oct 7, 2021 · 0 comments
Open

Clarify/Document Params parsing behavior #641

tomusdrw opened this issue Oct 7, 2021 · 0 comments

Comments

@tomusdrw
Copy link
Contributor

tomusdrw commented Oct 7, 2021

Follow up on the discussion in #640 (comment)

The clue is to clarify how we want the method implementation generated by derive to behave in case optional parameters are present.

Different cases:

  1. Positional parameters expected but there is no parameters or all parameters are optional.
  2. Named parameters expected but there is no parameters or all parameters are optional.
  3. Raw parameters expected.

The last case is simple - we simply let the user implementation to decide what to do. In case of (1) & (2) we need to clarify what kind of params are going to be accepted (empty array, empty object or Params::None).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant