Minor codegen hygiene improvements and modernizations #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to refactor the crate derive codegen to no longer require the extern crate specifier. Are there reasons we are still expanding to the "extern crate" here? We could simply use the identifier from the new parity_scale_codec_ident function prepended with :: everywhere. It would reflect a more modern (2018+) Rust macro codegen style.
… crate name This is either ::parity_scale_codec, crate or ::<name> where <name> refers to the name under which the parity-scale-codec crate has been imported by the dependent crate.
Robbepop
changed the title
bkchr
approved these changes
Sep 12, 2021
gui1117
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor macro hygiene issues such as
::core::marker::Sizedand::core::primitive::u8.Also it replaces the
extern crate $name as _parity_scale_codecby using the imported name:::scaleifparity_scale_codechas been renamed toscaleby the dependent cratecrateif the code is generated for the crate itself::parity_scale_codecfor tests of theparity_scale_codeccrate