-
Notifications
You must be signed in to change notification settings - Fork 1.7k
anyone can kill your contract #6995
Comments
Hmmh, clearly the kill came from registered owner, and required signatures was 0, see initWallet transaction arguments https://etherscan.io/tx/0x05f71e1b2cb4f03e547739db15d080fd30c989eda04d37ce6264c5686e0722c9 |
Will it effect the dependent multisig wallets? When i query " isowner(<any_addr>)" the multisig wallets returns TRUE. |
This comment has been minimized.
This comment has been minimized.
Hello, first of all i'm not the owner of that contract. I was able to make myself the owner of that contract because its uninitialized. These (https://pastebin.com/ejakDR1f) multi_sig wallets deployed using Parity were using the library located at "0x863df6bfa4469f3ead0be8f9f2aae51c91a907b4" address. I made myself the owner of "0x863df6bfa4469f3ead0be8f9f2aae51c91a907b4" contract and killed it and now when i query the dependent contracts "isowner(<any_addr>)" they all return TRUE because the delegate call made to a died contract. I believe some one might exploit. |
Hello! We've clashed this problem! Thanks Parity for the great contract again ;) |
For those Parity guys who doesn't believe that this exploit works - check out your library which were used by multiple multisigs: https://etherscan.io/address/0x863df6bfa4469f3ead0be8f9f2aae51c91a907b4#code |
It looks like |
@hlogeon 1. Why kill won't work? |
@devops199 |
"pragma solidity ^0.4.9;" released on 31 Jan |
How does it solves problem? |
Please read the details of the issue here: https://paritytech.io/blog/security-alert.html
|
The library is removed from the registry and all current Parity Wallet versions default to the WHG multi-signature wallets. |
Thought I'd post some resources to help people that come across this thread: In historical order: |
How come the last 2 links no longer work? |
@bernardpeh Our bad, blog engine update ruined some of the links. Thanks for reporting. |
FYI, the transaction that was submitted here: The transaction Successfully completed here: |
I accidentally killed it.
https://etherscan.io/address/0x863df6bfa4469f3ead0be8f9f2aae51c91a907b4
The text was updated successfully, but these errors were encountered: