This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fixed incorrect decoding of header seal_fields. added tests. #1090 #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what makes you think this is incorrect? unless something (everything) changed since i wrote this code, it is correct. |
gavofyork
added
A4-gotissues 💥
|
please see this comment https://github.com/ethcore/parity/issues/1090#issuecomment-219620535 and tests attached to pr |
| @@ -219,8 +219,8 @@ impl Header { | |||
| s.append(&self.timestamp); | |||
| s.append(&self.extra_data); | |||
| if let Seal::With = with_seal { | |||
| for b in &self.seal { | |||
| s.append_raw(&b, 1); | |||
| for b in &self.seal { | |||
There was a problem hiding this comment.
self.seal is a vector of post-RLP-encoded fields. It is not pre-RLP-encoded data. The reason for this is to allow for complex fields as part of the seal without having meta-RLP within the header.
There was a problem hiding this comment.
I see... than we have inconsistency in HeaderView struct, cause it returns pre-RLP-encoded data. I will update the pr.
debris
added
A0-pleasereview 🤓
|
updated the pr |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.