Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

simplified block opening #1232

Merged
merged 3 commits into from
Jun 13, 2016
Merged

simplified block opening #1232

merged 3 commits into from
Jun 13, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Jun 7, 2016

  • removed code duplicated in client's and miner's prepare_sealing.
  • renamed client prepare_sealing to prepare_open_block
  • prepare_open_block creates OpenBlock based on data available in blockchain. It does not push transactions

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Jun 7, 2016
@gavofyork
Copy link
Contributor

look fine - no tests though. suggest either writing one (best) or at least trying to mine a few blocks on a fresh morden.

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 7, 2016
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jun 13, 2016
@debris
Copy link
Collaborator Author

debris commented Jun 13, 2016

Tested mining on private chain. Everything works fine

@debris debris merged commit a8831fe into master Jun 13, 2016
@debris debris deleted the simplified_block_opening branch June 13, 2016 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debris @gavofyork