This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
delay bomb for Classic (ECIP-1010) #3179
Merged
gavofyork
merged 2 commits into
openethereum:master
from
ethereumproject:splix/bombdelay-2
Nov 4, 2016
Merged
delay bomb for Classic (ECIP-1010) #3179
gavofyork
merged 2 commits into
openethereum:master
from
ethereumproject:splix/bombdelay-2
Nov 4, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like @splix signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
gavofyork
added
A8-looksgood 🦄
Pull request is reviewed well.
M4-core ⛓
Core client code / Rust.
labels
Nov 4, 2016
rphmeier
reviewed
Nov 4, 2016
let ethparams = EthashParams { | ||
ecip1010_pause_transition: 3000000, | ||
ecip1010_continue_transition: 5000000, | ||
.. get_default_ethash_params() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: no space after ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean I need to remove space here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
rphmeier
pushed a commit
that referenced
this pull request
Jan 5, 2017
* delay bomb for classic (ECIP-1010) * formatting fix after core review, rel [e6b5093]
rphmeier
pushed a commit
that referenced
this pull request
Jan 5, 2017
* delay bomb for classic (ECIP-1010) * formatting fix after core review, rel [e6b5093]
gavofyork
pushed a commit
that referenced
this pull request
Jan 5, 2017
* delay bomb for Classic (ECIP-1010) (#3179) * delay bomb for classic (ECIP-1010) * formatting fix after core review, rel [e6b5093] * Replay protection for Classic * EIP-155 configuration for Ethereum Classic * EIP-160 configuration for Ethereum Classic * Testnet for Ethereum Classic * revert ETC to correct Network ID * reuse Morden for Classic Testnet * set CHAIN_ID for Classic (#3934) * configurable CHAIN_ID * set CHAIN_ID for Ethereum Classic * prettify classic json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementations for Bomb Delay that is planed for January ETC protocol upgrade (block 3,000,000). It's already implemented in Classic Geth, and these commits are adding compatibility for future fork into Parity as well.
See also:
Replaces PR #3144