Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ethash unsafety cleanup #3210

Merged
merged 1 commit into from
Nov 5, 2016
Merged

ethash unsafety cleanup #3210

merged 1 commit into from
Nov 5, 2016

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Nov 4, 2016

Separated out from #2445 as it should be pretty uncontroversial.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Nov 4, 2016
@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 5, 2016
@gavofyork
Copy link
Contributor

a bit less readable, but safer indeed.

@gavofyork gavofyork merged commit 56fd88d into master Nov 5, 2016
@gavofyork gavofyork deleted the ethash-unsafety-cleanup branch November 5, 2016 09:39
@rphmeier
Copy link
Contributor Author

rphmeier commented Nov 5, 2016

if anything, more readable...
the fact that Ethash::from_ethash was a function [u8; 32] -> H256 didn't make much sense at all

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @gavofyork