Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Parity configuration settings, i.e. mode #3212

Merged
merged 8 commits into from
Nov 5, 2016
Merged

Parity configuration settings, i.e. mode #3212

merged 8 commits into from
Nov 5, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 5, 2016

  • currently only handles setMode()
  • timeouts & alarms not available via RPC
  • expand when the above is available (which will also improve the UX here since it becomes more "meaty")

parity 2016-11-05 11-51-47

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Nov 5, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. B0-patch and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 5, 2016
@gavofyork gavofyork merged commit 458ee4c into master Nov 5, 2016
@gavofyork gavofyork deleted the jg-parity-mode branch November 5, 2016 11:08
arkpar pushed a commit that referenced this pull request Nov 5, 2016
* Add initial page

* Add parity icon

* opacity for parity icon

* Mode selector

* Actually set mode when value changes
gavofyork pushed a commit that referenced this pull request Nov 5, 2016
* Mode improvements for UI (#3109)

* `--mode=off` now works.

* Add Mode::Off as a persistent CLI option.

* "last" not "auto" as default.

* Commit accidentally unsaved file.

* Whitespace

[ci:skip]

* Mode CLI parse fix

* or offline

* Save mode when it gets changed.

* Fix Offline mode

* Fix up mode operations.

* Make passive default, but not overriding.

* Fix test

* Maybe not everyone wants to run an archive node...

* Parity configuration settings, i.e. mode (#3212)

* Add initial page

* Add parity icon

* opacity for parity icon

* Mode selector

* Actually set mode when value changes
@derhuerst
Copy link
Contributor

It may be confusing that this tab is named "Parity", because for non-technical users the UI may actually represent the major part of Parity. I propose e.g. "Node" or "Network".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants