Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Default contract type on UI #3310

Merged
merged 5 commits into from
Nov 10, 2016
Merged

Default contract type on UI #3310

merged 5 commits into from
Nov 10, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Nov 9, 2016

Closes #3281 and #3126

Adds a contract type selector on Watch Contract modal. Better ABI validation (validates that each Object of the Array is actually an event or a function/constructor).

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Nov 9, 2016
@ngotchac
Copy link
Contributor Author

ngotchac commented Nov 9, 2016

image

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Nov 9, 2016
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 9, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 9, 2016
@gavofyork gavofyork merged commit 67ac05e into master Nov 10, 2016
@gavofyork gavofyork deleted the ng-abi-enhancement branch November 10, 2016 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants