This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Better GHH event display & tracking #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Nov 17, 2016
•
jacogr
commented
- Show posted event confirmation for GHH (tracking what we have done - contract has no events of its own)
- Posted events appear in gray (busy), white (done) & red (error)
- Allow multiple concurrent events - Closes https://github.com/ethcore/parity/issues/3099
- Handle signer & transport errors gracefully - Closes https://github.com/ethcore/parity/issues/3097
- Make info hash display explicit with green, orange & red info overlays- Closes https://github.com/ethcore/parity/issues/3101
jacogr
added
A0-pleasereview 🤓
ngotchac
suggested changes
Nov 18, 2016
|
|
||
| renderEvent = (eventId, event) => { | ||
| return ( | ||
| <tr key={ `event_${eventId}` } data-busy={ event.registerBusy } data-error={ event.registerError }> |
There was a problem hiding this comment.
Warning: validateDOMNesting(...): <tr> cannot appear as a child of <table>. See Events > table > tr. Add a <tbody> to your code to match the DOM tree generated by the browser.
There was a problem hiding this comment.
Grrr... Sorry, that is a noob mistake. (Also kicking myself for not spotting it, it is very obvious and the error was there.)
ngotchac
added
A4-gotissues 💥
|
Small React issue. Looks good otherwise |
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.