This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Move Signer balance queries to store for component-wide re-use #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
|
Although it's only a small part of cleaning up the signer, it looks good! 👍 |
derhuerst
added
A7-looksgoodtestsfail 🤖
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
ngotchac
reviewed
Nov 23, 2016
| } | ||
|
|
||
| fetchBalances (addresses) { | ||
| addresses.forEach((address) => { |
There was a problem hiding this comment.
Use of MobX transaction ?
There was a problem hiding this comment.
NM, transaction isn't for async...
There was a problem hiding this comment.
Yes, as soon as you bring a promise in the transaction doesn't quite work - can only use it where setting the values, not wrapping a Promise. (Tried the former in my first attempt, however useStrict doesn't like that approach at all.)
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signer additions, 2 of n... Follow practices elsewhere where APIs are localised to stores, DRY-ing up queries, all within a single store.
Closes https://github.com/ethcore/parity/issues/3523