i18n string dictionaries #3532
i18n string dictionaries #3532
Conversation
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
|
@ngotchac & @derhuerst Comments welcome. |
# Conflicts: # js/src/views/Application/TabBar/tabBar.js
|
Improved the German translations, but haven't looked at the code yet. |
|
Qt's i18n support is light-years ahead of Javascript, it seems. |
|
Sadly, yes, especially when it comes to React + JS. (Then again, I did Qt i18n around 2001, so it has had a lot of time.) It is basically only a dictionary of strings, with replacements, i.e. can do "you have %{count} messages". But overall could whip this up, in this form, in an afternoon. There are some things not in here with regards date formatting (as well as currencies) and plurals, but once again, nothing to write home about. There is also the Yahoo React i18n package, which is in the same vein (slightly stronger with actual formatting). |
|
There should be something |
| // You should have received a copy of the GNU General Public License | ||
| // along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| import { initLocales, getLocale, setLocale } from './i18n'; |
There was a problem hiding this comment.
Why not move i18n/i18n.js to i18n/index.js?
There was a problem hiding this comment.
Could work and make it simpler.
| @@ -29,6 +29,9 @@ import qs from 'querystring'; | |||
|
|
|||
| import SecureApi from './secureApi'; | |||
| import ContractInstances from './contracts'; | |||
| import { initLocales } from './i18n'; | |||
|
|
|||
| initLocales('en'); | |||
There was a problem hiding this comment.
I find the naming initLocales confusing. It sounds as if you could pass one or more locales to be initialised, in this case only English. However, underneath, all locales will be initialised, with English being the chosen one.
| function flattenObject (localeObject) { | ||
| return Object | ||
| .keys(localeObject) | ||
| .reduce((obj, key) => { |
There was a problem hiding this comment.
Tiny grumble: I'd prefer more expressive var names like obj -> all, key -> ns/base, flatKey -> key.
Also, consider a module like: flat. I handles edge cases like arrays (typeof [] === 'object') and is well-tested.
But this is far from blocking this PR. (:
There was a problem hiding this comment.
Agreed. Should be removed and inputs done properly as per the defaultMessage output file. (See later comment.)
| @observable isDevelopment = !isProduction; | ||
|
|
||
| constructor () { | ||
| addLocaleData([...de, ...en]); |
There was a problem hiding this comment.
Really not sure here…
This should probably get called only once during runtime, as it has static arguments anyway. If I created two stores, it would get called twice. What about moving it up, below LOCALES?
| <div> | ||
| <FormattedMessage | ||
| id='settings.background.overview_0' | ||
| defaultMessage='The background pattern you can see right now is unique to your Parity installation. It will change every time you create a new Signer token. This is so that decentralized applications cannot pretend to be trustworthy.' /> |
There was a problem hiding this comment.
If we have a defaultMessage (which I think is good for readability), we do we need a separate en i18n file? They will probably not stay consistent over time.
There was a problem hiding this comment.
Good point, don't think I explained it properly. Will bring in the babel/webpack plugin to extract the messages, i.e. you can generate a file from the defaultMessages at build and use this as an input into the translation.
(There are some text still in the English file, since they are used at multiple places, same text, same reference, just duplicated - kept it that way for now since it removes the duplication. Needs to be put back, not duplicated)
jacogr
added
A3-inprogress ⏳
# Conflicts: # ethcore/light/src/types/mod.rs # js/package.json # js/src/i18n/en/index.js # js/src/modals/SMSVerification/GatherData/gatherData.js # js/src/modals/SMSVerification/SendConfirmation/sendConfirmation.js # js/src/modals/SMSVerification/SendRequest/sendRequest.js # js/src/ui/index.js # js/src/util/nullable-proptype.js # js/src/util/proptypes.js # js/src/views/Settings/Parity/parity.js
jacogr
added
A0-pleasereview 🤓
Testing i18n React implementation