This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Invalidate blocks from future #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
arkpar
reviewed
Nov 28, 2016
| InvalidTimestamp(OutOfBounds { max: Some(get_time().sec as u64 + 30), min: None, found: header.timestamp() })); | ||
|
|
||
| header = good.clone(); | ||
| header.set_timestamp(get_time().sec as u64 + 31); |
There was a problem hiding this comment.
This will make the test fail spuriously if the blocks check happens to hit the next second interval. Please set to something like + 40 instead.
There was a problem hiding this comment.
32 should be enough unless the test takes longer than a second to execute for some reason. I'd put 40 just to be safe.
There was a problem hiding this comment.
hm, ok. I considered 2 seconds for such test as a failure already
arkpar
reviewed
Nov 28, 2016
| @@ -516,6 +522,16 @@ mod tests { | |||
| InvalidTimestamp(OutOfBounds { max: None, min: Some(parent.timestamp() + 1), found: header.timestamp() })); | |||
|
|
|||
| header = good.clone(); | |||
| header.set_timestamp(2450000000); | |||
| check_fail(basic_test(&create_test_block_with_data(&header, &good_transactions, &good_uncles), engine), | |||
| InvalidTimestamp(OutOfBounds { max: Some(get_time().sec as u64 + 30), min: None, found: header.timestamp() })); | |||
There was a problem hiding this comment.
This will make the test fail spuriously if the blocks check happens to hit the next second interval. Test should just check if this is an InvalidTimestamp error.
arkpar
reviewed
Nov 28, 2016
| header = good.clone(); | ||
| header.set_timestamp(get_time().sec as u64 + 31); | ||
| check_fail(basic_test(&create_test_block_with_data(&header, &good_transactions, &good_uncles), engine), | ||
| InvalidTimestamp(OutOfBounds { max: Some(get_time().sec as u64 + 30), min: None, found: header.timestamp() })); |
arkpar
added
A5-grumble 🔥
gavofyork
added
A4-gotissues 💥
|
@arkpar fixed |
arkpar
added
A8-looksgood 🦄
gavofyork
added
B7-releasenotes 📜
|
@jesuscript / @General-Beck the gitlab CI isn't firing? |
|
I think it's because Gitlab only builds branches in the main repo (not PRs) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decline blocks which have a timestamp from future (more than 30 seconds from current time). Otherwise malicious miner can use block with invalid timestamp to attack the network.