Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refactoring Transfer Modal #3705

Merged
merged 10 commits into from
Dec 2, 2016
Merged

Refactoring Transfer Modal #3705

merged 10 commits into from
Dec 2, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Dec 2, 2016

Refactor the Transfer modal (splitting #3700 in smaller chunks) ; use a Mobx store.

Add small fixes here and there.

Better MethodDecoding input display (go from ASCII to Hex, expand or not...)

Adds a new method to Contract API : getAll which returns all the logs for an event or just for any filter.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 2, 2016
return event;
}

getAll (event, _options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAllLogs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 2, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.996% when pulling 45cf565 on ng-transfer-enhanc into 3837114 on master.

@jacogr jacogr merged commit c892a4f into master Dec 2, 2016
@jacogr jacogr deleted the ng-transfer-enhanc branch December 2, 2016 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants