This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update JS dependencies #3710
Merged
Update JS dependencies #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 640022c on ng-ui-updates into ** on master**. |
jacogr
reviewed
Dec 3, 2016
| @@ -98,7 +95,7 @@ if (module.hot) { | |||
| // // <AppContainer> | |||
| // // <ContextProvider api={ api } muiTheme={ muiTheme } store={ newStore }> | |||
| // // <MainApplication | |||
| // // routerHistory={ routerHistory } | |||
| // // routerHistory={ hashHistory } | |||
There was a problem hiding this comment.
Can we remove this block now?
There was a problem hiding this comment.
We sure can. It's just that right now whenever the Redux store is modified, the whole app has to refresh. With a bit of work, this could be hot reloaded
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update every JS dependencies to their latest version, except 2.
Some unused dependencies have been removed too.
Not updated:
recharts0.15.2 -> 0.19.0 : something seems to be breaking the GasPriceSelector, might as well wait for v1 to fix itpostcss-import8.1.0 -> 8.2.0 : updating breaks completely the build. It seems to be fixed (object-assign: no such file or directory postcss/postcss-import#207) in the future v9 release