Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add parity_removeAddress RPC #3735

Merged
merged 3 commits into from
Dec 7, 2016
Merged

Add parity_removeAddress RPC #3735

merged 3 commits into from
Dec 7, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 7, 2016

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API. labels Dec 7, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Dec 7, 2016

Rust side LGTM

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 7, 2016
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 7, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 7, 2016
@gavofyork gavofyork merged commit 3423573 into master Dec 7, 2016
@gavofyork gavofyork deleted the jg-addressbook-delete branch December 7, 2016 17:31
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 85.941% when pulling dba8cf3 on jg-addressbook-delete into 1f0a02b on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacogr @rphmeier @coveralls @gavofyork