Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

LES Part 3: Event handlers and handling responses #3755

Merged
merged 19 commits into from
Dec 9, 2016
Merged

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Dec 9, 2016

Enable the light server with the --serve-light flag. More specific configuration of buffer flow parameters and such will be in the next PR.

Up next:

  • request timeouts (currently they'll just pend forever)
  • CHT on the server side (how much of this do we want to support?)
  • ensure compatibility with geth's LES. Right now there are some messages formatted differently and I'll need to spend quite a bit of time checking and double-checking request formatting. best to get this in review first
  • light-sync implementation

To help review:

  • EventContext is similar to the NetSyncIo trait in the sync module, only that it's relevant to a higher level set of events than a basic NetworkProtocolHandler.
  • I discovered that the buffer flow arguments are actually optional in the handshake pretty late on, although the spec is a bit ambiguous on that point. So handshake parsing has gotten a bit more lenient
  • There's a bit of cargo-feature shuffling and I think the IPC code I've written will work but IPC build of ethcore crate is still broken and all my code lives above it for now. These parts of the PR aren't really that important

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 9, 2016
@rphmeier rphmeier requested a review from arkpar December 9, 2016 00:41
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7eeac23 on lightserv into ** on master**.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 85.898% when pulling 7eeac23 on lightserv into f9a24f3 on master.

@rphmeier rphmeier changed the title LES Part 3: Event handlers and serving requests LES Part 3: Event handlers and handling responses Dec 9, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 9, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 503b126 on lightserv into ** on master**.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 85.589% when pulling 503b126 on lightserv into 2226324 on master.

@rphmeier rphmeier merged commit 4d25445 into master Dec 9, 2016
@rphmeier
Copy link
Contributor Author

rphmeier commented Dec 9, 2016

(travis failure unrelated, tests passed before merge and now locally)

@rphmeier rphmeier deleted the lightserv branch December 9, 2016 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants