Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Additional RPCs for dapps accounts management #3792

Merged
merged 6 commits into from
Dec 15, 2016
Merged

Conversation

tomusdrw
Copy link
Collaborator

Closes #3771

By default eth_accounts will return all accounts (as it was before), but it's possible to change policy for new dapps to return only specified whitelist of accounts.

Additionally recent dapps are available in RPC to simplify GUI for that.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Dec 10, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.635% when pulling 4696d7f on dapps-accounts-rpc into 6eb63a7 on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 10, 2016
@gavofyork
Copy link
Contributor

gavofyork commented Dec 10, 2016

it's possible to change policy

policy should be secure by default.

that users are accustomed to insecure operation is no reason to continue that folly.

@gavofyork gavofyork added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Dec 10, 2016
@tomusdrw
Copy link
Collaborator Author

Changed the default policy to return empty list as requested. Marking it as B1-relnotes since if it somehow gets released without a proper UI it makes all the dapps useless without an additional RPC call.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Dec 11, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.626% when pulling 627b8a8 on dapps-accounts-rpc into 6eb63a7 on master.

@gavofyork
Copy link
Contributor

right - will leave it here until @jacogr / @ngotchac make such a UI :-)

@jacogr
Copy link
Contributor

jacogr commented Dec 12, 2016

@gavofyork & @tomusdrw - UI in progress.

First round will only be to set the default accounts (available to all dapps) until we have a better way of determining the appids. (Currently it would be the contentHash, which means that each update will force the user to go re-auth their dapps.)

@tomusdrw
Copy link
Collaborator Author

I would rather merge this PR if possible even before the UI - it's still an improvement over what we have in master (it allows you to customize the policy).

@gavofyork
Copy link
Contributor

ok - if so then we'll need to switch the default policy :-)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1ea521e on dapps-accounts-rpc into ** on master**.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 15, 2016
@gavofyork gavofyork merged commit 4d6b4d9 into master Dec 15, 2016
@gavofyork gavofyork deleted the dapps-accounts-rpc branch December 15, 2016 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants