This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix React-Router in i18n locale change #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A8-looksgood 🦄
|
Changes Unknown when pulling 5716609 on ng-i18n into ** on master**. |
jacogr
added
A0-pleasereview 🤓
|
Looks good, however just do the "Ethcore" -> "Parity Technologies" header updates. |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the React-Router warning/error log when changing the UI locale : converts JSX routes to a route file config. This will also fix the same error while hot reloading any part of the App.
Save the chosen locale to localstorage so it doesn't get reset on reload.