This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fetch certifiers only when needed #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Dec 27, 2016
| logs = contract.parseEventLogs(logs); | ||
| logs.forEach((log) => { | ||
| const certifier = certifiers.find((c) => c.address === log.address); | ||
| if (!certifier) { | ||
| console.warn(certifiers, log); |
There was a problem hiding this comment.
We should add at least which function it comes from (although it is implicit)
There was a problem hiding this comment.
That's a debug I forgot to remove...
jacogr
reviewed
Dec 27, 2016
| const Confirmed = contract.events.find((e) => e.name === 'Confirmed'); | ||
| const Revoked = contract.events.find((e) => e.name === 'Revoked'); | ||
|
|
||
| return (store) => { | ||
| const onLogs = (logs) => { | ||
| let certifiers = []; | ||
| let accounts = []; // these are addresses |
There was a problem hiding this comment.
Shouldn't we rather name it "addresses" instead of the comment?
There was a problem hiding this comment.
I guess we could (was like this already in the code)
jacogr
reviewed
Dec 27, 2016
| return this._registry | ||
| .getContract('badgereg') | ||
| return this | ||
| .getContract() |
There was a problem hiding this comment.
+1 Definitely prefer this approach & consistency.
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't fetch certifiers one every new page navigation (eg. switching from accounts to address book triggers a fetch for every certifiers, which on Ropsten outputs warnings logs for inexisting ones).
Fetch them once, and then fetch when needed based on Event Logs.