This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Work on Portal Style #4003
Merged
Work on Portal Style #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Dec 30, 2016
| $left: 1.5em; | ||
| $right: $left; | ||
| $bottom: $left; | ||
| $top: 15vh; |
There was a problem hiding this comment.
Probably would have gone slightly larger (20vh?) just to give slightly more modal context.
jacogr
reviewed
Dec 30, 2016
| <div | ||
| className={ classes.join(' ') } | ||
| onKeyDown={ this.handleKeyDown } | ||
| onClick={ this.stopEvent } |
There was a problem hiding this comment.
onClick before onKeyDown, but just my OCD kicking in. (Doesn't make a huge difference here with the small amount of attributes but prefer following a pattern everywhere for the sake of consistency)
|
Looks as good as we will probably get with this style for 1.5, some small throw-away comments made. |
jacogr
added
A8-looksgood 🦄
|
Changes Unknown when pulling 48e638b on ng-portal-style into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the Portal size, close on click outside of the Portal content.