This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Connection UI cleanups & tests for prior PR #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Jan 3, 2017
jacogr
commented
- Slight code formatting cleanups
- Add tests and verify previous fixes in Fix manual input token #3945
ngotchac
reviewed
Jan 4, 2017
| } | ||
|
|
||
| export default connect( | ||
| mapStateToProps, | ||
| mapDispatchToProps | ||
| null |
There was a problem hiding this comment.
This line (null) can just be omitted.
There was a problem hiding this comment.
I prefer to be explicit, hence putting that in there.
| @@ -17,7 +17,6 @@ | |||
| import React, { Component, PropTypes } from 'react'; | |||
| import { FormattedMessage } from 'react-intl'; | |||
| import { connect } from 'react-redux'; | |||
| import { bindActionCreators } from 'redux'; | |||
| import ActionCompareArrows from 'material-ui/svg-icons/action/compare-arrows'; | |||
| import ActionDashboard from 'material-ui/svg-icons/action/dashboard'; | |||
| import HardwareDesktopMac from 'material-ui/svg-icons/hardware/desktop-mac'; | |||
There was a problem hiding this comment.
Shouldn't we use the new ui/Icons exports there while touching this file?
There was a problem hiding this comment.
Actually, probably, yes. However I left those in there on purpose since the icons they are actually non-button icons where the rest are all meant for buttons.
ngotchac
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.