This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Only fetch App when necessary #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jan 4, 2017
| return ( | ||
| <div className={ styles.full }> | ||
| <div className={ styles.text }> | ||
| The dapp <code title={ id }>{ id }</code> can't be reached |
There was a problem hiding this comment.
Would have preferred this (and the Loading above) to be FormattedMessages since we are adding new and don't have to come back to it later.
jacogr
reviewed
Jan 4, 2017
| ]); | ||
| } | ||
|
|
||
| loadApps () { |
There was a problem hiding this comment.
Probably makes a bit more sense naming this loadAllApps to be more specific (and since we have loadLocalApps (if changed only external call is from views/dapps)
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3914
When opening a dapp, only load this one instead of loading all available dapps.
Adds a message if the dapp could not be found.