Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix tags not working #4070

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Fix tags not working #4070

merged 1 commit into from
Jan 6, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Jan 6, 2017

Tags weren't properly working (from the Accounts view) after having visited a specific Account page ; meaning that clicking on a tag wouldn't filter accounts correctly.

This was because of MobX implementation of Arrays as Object (thus not concatenating properly).

Small UI glitches fixes too.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 6, 2017
@derhuerst derhuerst added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 6, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a6c275d on ng-fix-tags into ** on master**.

@jacogr jacogr merged commit 81641a5 into master Jan 6, 2017
@jacogr jacogr deleted the ng-fix-tags branch January 6, 2017 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants