fix subscribeToEvents test #4166
Conversation
This fix is a workaround. I would have used sinon fake timers, but I couldn't get them to work.
| .on('log', onLog) | ||
| .on('Bar', onBar); | ||
| await delay(9); | ||
| s.unsubscribe(); | ||
| await delay(10); |
There was a problem hiding this comment.
Need to be sure promise are resolved or event emitted before testing the expectations, currently everything just waits for some hopefully long enough time instead.)
There was a problem hiding this comment.
Need to be sure promise are resolved or event emitted […]
The promises definitely resolve on next tick, because they are mocked.
[…] currently everything just waits for some hopefully long enough time instead.
That the events fire within a certain time period is actually what this test tries to assert.
|
Changes Unknown when pulling 98300d3 on jr-fix-subscribe-test into ** on master**. |
|
Not 100% on-board with approach, however it is an test and it does seem to be at least semi-stable at this point. Not going to gumble about it, we have real issues to address. |
jacogr
added
A6-mustntgrumble 💦
This PR is a follow-up of #4138. It fixes the flaky test for
util/subscribe-to-events.It is not the most beautiful way to test this though. I would have preferred to use fake timers but couldn't get it to work in a reasonable time.