This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing minimal transaction queue price #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Jan 18, 2017
| @@ -1123,6 +1123,9 @@ impl MinerService for Miner { | |||
| // First update gas limit in transaction queue | |||
| self.update_gas_limit(chain); | |||
|
|
|||
| // Update minimal gas price | |||
| self.recalibrate_minimal_gas_price(); | |||
There was a problem hiding this comment.
wouldn't this lead to sending off an HTTP request every time chain_new_blocks is called? (potentially multiple times per second)
There was a problem hiding this comment.
Previously it was done in prepare_block, so for mining nodes it was (almost) the same (chain_new_blocks event is not sent to miner if we're syncing afaik)
Also GasCalibrator supports a minimal interval between calibrations:
https://github.com/ethcore/parity/blob/8517369372f2e151dedf5d6f1b6c32bd372453da/ethcore/src/miner/miner.rs#L147-L167
so I don't see an issue here.
There was a problem hiding this comment.
Yes, I see now, just leaving a comment as I skimmed through it
arkpar
added
A8-looksgood 🦄
gavofyork
added
A7-looksgoodtestsfail 🤖
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Jan 19, 2017
* Fixing minimal transaction queue price * Fixing tests
arkpar
added a commit
that referenced
this pull request
Jan 19, 2017
* JsonRPC bump for IPC fix * Fixing etherscan price parsing (#4202) * Fixing etherscan price parsing * Handling all errors * Fixed --base-path on windows (#4193) * Fixed --base-path on windows * Add support for optional args with default text * Fixing minimal transaction queue price (#4204) * Fixing minimal transaction queue price * Fixing tests * verification: add mainnet BadgeReg ids (#4190) * verification: mainnet BadgeReg ids * verification: fetch contracts by name * verification: better wording * typo * reregistered badges * Console now has admin (#4220) Fixes #4210 * Non-secure for DappReg (#4216)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4199
Closes #4198