This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 rules, both where we have been making comments on PRs which could just be caught by eslint. (Applied auto-fixes and actually checked/adjusted in a couple of cases where fixes were done not quite 100%)
newline-after-var
- eslint found us mostly consistent here, however around 320 auto-fixes applied. Always preferinstead of
one-var-declaration-per-line
- eslint found us 99.99% compliant, auto-fixes applied in 6 files. Always preferinstead of