Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Eslint formatting updates #4234

Merged
merged 8 commits into from
Jan 23, 2017
Merged

Eslint formatting updates #4234

merged 8 commits into from
Jan 23, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 20, 2017

Added 2 rules, both where we have been making comments on PRs which could just be caught by eslint. (Applied auto-fixes and actually checked/adjusted in a couple of cases where fixes were done not quite 100%)

  1. newline-after-var - eslint found us mostly consistent here, however around 320 auto-fixes applied. Always prefer
const foo = '123';
let bar;

if (xyz === foo) {
  return;
}

instead of

const foo = '123';
let bar;
if (xyz === foo) {
  return;
}
  1. one-var-declaration-per-line - eslint found us 99.99% compliant, auto-fixes applied in 6 files. Always prefer
let foo = '123';
let bar;
let baz;

instead of

let foo = '123, bar, baz;

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 20, 2017
@jacogr jacogr added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 20, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jan 20, 2017
@ngotchac
Copy link
Contributor

All right for me. Might want to wait for @derhuerst opinion

@jacogr jacogr mentioned this pull request Jan 20, 2017
@ngotchac ngotchac added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 23, 2017
# Conflicts:
#	js/src/redux/providers/balancesActions.js
#	js/src/secureApi.js
#	js/src/views/Application/store.js
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Jan 23, 2017
@jacogr jacogr merged commit 66e540e into master Jan 23, 2017
@jacogr jacogr deleted the jg-eslint-newlines branch January 23, 2017 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants