Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix eth_sign/parity_postSign #4432

Merged
merged 4 commits into from
Feb 4, 2017
Merged

Fix eth_sign/parity_postSign #4432

merged 4 commits into from
Feb 4, 2017

Conversation

gavofyork
Copy link
Contributor

@gavofyork gavofyork commented Feb 4, 2017 •
edited
Loading

eth_sign (and parity_postSign) used to return concatenated r ++ s ++ v with v being 0 or 1. it now agrees with geth as v ++ r ++ s with v being 27 or 28.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. B0-patch B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. labels Feb 4, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 4, 2017
@arkpar arkpar merged commit 4553f51 into master Feb 4, 2017
@arkpar arkpar deleted the fix-things branch February 4, 2017 15:00
arkpar pushed a commit that referenced this pull request Feb 4, 2017
@gavofyork @arkpar
Fix eth_sign/parity_postSign (#4432)
6cb1524 
* Fix dispatch for signing.

* Remove console log

* Fix signing & tests.
arkpar added a commit that referenced this pull request Feb 4, 2017
@arkpar
Backporting to beta (#4434)
9912a31 
* v1.5.2

* Fix eth_sign/parity_postSign (#4432)

* Fix dispatch for signing.

* Remove console log

* Fix signing & tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavofyork @arkpar