Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix contract queries bug #4534

Merged
merged 3 commits into from
Feb 14, 2017
Merged

Fix contract queries bug #4534

merged 3 commits into from
Feb 14, 2017

Conversation

ngotchac
Copy link
Contributor

Fixes #4520

Add an option to the call method (for functions of a contract) to output the raw tokens (Token class, with type and value attributes) instead of token.value.

Fixes some UI and logic bugs in the Address Selector too.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Feb 13, 2017
@ngotchac ngotchac changed the title Ng fix contract Fix contract queries bug Feb 13, 2017
{ this.renderContent() }
</Card>
);
}

renderError () {
Copy link
Contributor

@jacogr jacogr Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really be using newError so we UI-wide consistent display. The only errors we display inline anywhere are the field validation errors.

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 14, 2017
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Feb 14, 2017
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 14, 2017
@jacogr jacogr merged commit e8597e2 into master Feb 14, 2017
@jacogr jacogr deleted the ng-fix-contract branch February 14, 2017 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants