This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Tooltips with react-intl #4549
Merged
Tooltips with react-intl #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
approved these changes
Feb 15, 2017
| currentId: PropTypes.number, | ||
| maxId: PropTypes.number, | ||
| className: PropTypes.string, | ||
| right: PropTypes.bool, |
There was a problem hiding this comment.
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-prop-types.md
Should we ? (PS, r is after o 😆)
There was a problem hiding this comment.
Funnily enough, I played with that some weeks ago - it does some nice stuff, e.g. required first, then normal, then handlers (onSomething) - obviously all ordered. (Or you can just order without caring about the type)
There was a problem hiding this comment.
We should, the only reason I have not pulled it in as part of one of my eslint updates (yet) is that we are basically wrong in 70% of the cases. So lot of small little niggly updates, just didn't have the time to fiddle.
Medium-term, I would love to.
ngotchac
added
A6-mustntgrumble 💦
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Split from https://github.com/ethcore/parity/pull/4539)
~/ui/Tooltips/TooltipFormattedMessagewhere Tooltips are constructed