This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
More CLI settings for IPFS API #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejhirsz
added
A0-pleasereview 🤓
tomusdrw
reviewed
Feb 20, 2017
ipfs/src/lib.rs
Outdated
|
|
||
| pub fn new(cors: Option<Vec<String>>, hosts: Option<Vec<String>>, client: Arc<BlockChainClient>) -> Self { | ||
| fn origin_to_header(origin: String) -> AccessControlAllowOrigin { | ||
| if origin == "*" { |
There was a problem hiding this comment.
Should handle null as well (file:/// and sandboxed iframes)
ipfs/src/lib.rs
Outdated
| pub struct IpfsHandler { | ||
| /// Response to send out | ||
| out: Out, | ||
|
|
There was a problem hiding this comment.
Why put those new lines? I think I a compact form more.
|
|
||
| cors_domains.iter().any(|domain| match *domain { | ||
| AccessControlAllowOrigin::Value(ref allowed) => origin == allowed, | ||
| AccessControlAllowOrigin::Any => true, |
There was a problem hiding this comment.
This is already fixed, you just can't see it on the diff here (it's one line below).
| } | ||
| } | ||
|
|
||
| if let Some(cors_header) = cors::get_cors_header(&self.cors_domains, &self.origin) { | ||
| res.headers_mut().set(cors_header); |
There was a problem hiding this comment.
It should also send Access-Control-Allow-Methods, Access-Control-Allow-Headers and Vary: Origin headers.
There was a problem hiding this comment.
Access-Control-Allow-Methods and Access-Control-Allow-Headers are only necessary in preflight requests, currently non-GET requests get killed outright so there is no need for them. I've added Vary.
ipfs/src/lib.rs
Outdated
| port: u16, | ||
| interface: String, | ||
| cors: Option<Vec<String>>, | ||
| hosts: Option<Vec<String>>, |
rphmeier
added
A5-grumble 🔥
maciejhirsz
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ipfs-api-interface.--ipfs-api-hosts.--ipfs-api-cors.HostorOriginheader is sent to avoid side effects.parity/configuration.rs.