Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Default account selection update #4609

Merged
merged 13 commits into from
Feb 22, 2017
Merged

Default account selection update #4609

merged 13 commits into from
Feb 22, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Feb 20, 2017 •
edited
Loading

  • handles the empty/all selected accounts cases
  • only set the default account (no full list updates in Signer selector)

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M7-ui labels Feb 20, 2017
@gavofyork gavofyork removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Feb 20, 2017
@jacogr
Merge branch 'master' into jg-ui-default-update
7774575 
# Conflicts:
#	js/src/modals/DappPermissions/store.js
#	js/src/views/ParityBar/accountStore.js
@jacogr
Update failing tests (after merge)
177d4f8
ngotchac
ngotchac suggested changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@ngotchac ngotchac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One method is wrong. Plus, when deselecting every account from the Dapps Permission modal, some errors are printed to the console when closing the modal, and it should not let the user deselect every account.

js/src/views/ParityBar/accountStore.js Outdated

return this._api.parity
.setNewDappsAddresses(accounts)
.setNewDappsDefaultAccount(defaultAddress)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setNewDappsDefaultAddress

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Thought I killed all the merge issues.

@ngotchac ngotchac added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 21, 2017
@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Feb 21, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 21, 2017
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 21, 2017
@gavofyork gavofyork merged commit 5337bf6 into master Feb 22, 2017
@gavofyork gavofyork deleted the jg-ui-default-update branch February 22, 2017 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ngotchac ngotchac ngotchac approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacogr @ngotchac @gavofyork @tomusdrw