This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Convert all remaining Modals to use Portal (UI consistency) #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
derhuerst
reviewed
Feb 22, 2017
| onClick={ onClose } | ||
| /> | ||
| ); | ||
|
|
||
| if (error) { | ||
| return (<div>{ cancel }</div>); | ||
| return ( |
There was a problem hiding this comment.
While we're about to change it, this could be return cancel; afaik.
derhuerst
reviewed
Feb 22, 2017
js/src/ui/Actionbar/Import/import.js
Outdated
| onClose={ this.onCloseModal } | ||
| open | ||
| steps={ | ||
| hasSteps |
There was a problem hiding this comment.
Would like to have this moved out. It's a little too hard to read.
derhuerst
reviewed
Feb 22, 2017
js/src/ui/Portal/portal.js
Outdated
| @@ -156,9 +153,13 @@ export default class Portal extends Component { | |||
| handleClose = () => { | |||
| const { hideClose, onClose } = this.props; | |||
|
|
|||
| console.log('handleClose'); | |||
There was a problem hiding this comment.
Most likely this has stayed here by accident.
Would not like to make the console more noisy. Either use a solution like import 'debug' or remove it.
derhuerst
reviewed
Feb 22, 2017
js/src/ui/Theme/theme.js
Outdated
| @@ -38,6 +38,8 @@ muiTheme.textField.hintColor = 'rgba(255, 255, 255, 0.5)'; | |||
| muiTheme.textField.disabledTextColor = muiTheme.textField.textColor; | |||
| muiTheme.toolbar = lightTheme.toolbar; | |||
| muiTheme.toolbar.backgroundColor = 'transparent'; | |||
| muiTheme.zIndex.layer = 4000; | |||
| muiTheme.zIndex.popovr = 4100; | |||
There was a problem hiding this comment.
popover. As it seemed to work before, you might be able to remove it.
derhuerst
reviewed
Feb 22, 2017
| } | ||
|
|
||
| onNewWalletClose = () => { | ||
| this.onNewWalletClick(); | ||
| this.setState({ | ||
| newWalletDialog: false |
|
LGTM! only a few cleanups left over. |
derhuerst
reviewed
Feb 22, 2017
| @@ -41,7 +41,7 @@ function create () { | |||
| store = new Store(api); | |||
| } | |||
|
|
|||
| describe.only('modals/DappPermissions/store', () => { | |||
| describe('modals/DappPermissions/store', () => { | |||
There was a problem hiding this comment.
Don't even ask, sloppy.
|
The layout could be nicer in some of the screens, but there are far more important issues to be tackled. |
derhuerst
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also closes https://github.com/ethcore/parity/issues/4620, supercedes https://github.com/ethcore/parity/issues/4620)
TODO:
FirstRun -
CreateAccount -
CreateWallet -
Transfer -
ShapeShift -
Verification -
EditMeta -
PasswordManager -
WalletSettings -
AddAddress -
AddContract -
DeployContract -
ExecuteContract -
LoadContract -
SaveContract -
UpgradeParity -