This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix Geth account import #4641
Merged
Fix Geth account import #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Feb 22, 2017
| return this._api.parity.setAccountMeta(address, { | ||
| timestamp | ||
| .then((gethImported) => { | ||
| console.log('createAccountFromGeth', gethImported); |
There was a problem hiding this comment.
could be console.info to reduce noise.
There was a problem hiding this comment.
On purpose - very specific "noise" in this case for an operation that happens once-off. So going to "ignore" the comment, but understand the concern very much for anything that is not basically a once-off :)
There was a problem hiding this comment.
In this case console.info helps devs filter out logs irrelevant to their current problem.
derhuerst
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ethcore/parity/issues/4279