This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Propagate trie errors upwards from State #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
(To support non trie-based backends we might want an associated |
arkpar
reviewed
Feb 25, 2017
ethcore/src/state/mod.rs
Outdated
| @@ -186,8 +195,8 @@ impl AccountEntry { | |||
| /// checkpoint can be discateded with `discard_checkpoint`. All of the orignal | |||
| /// backed-up values are moved into a parent checkpoint (if any). | |||
| /// | |||
| pub struct State { | |||
| db: StateDB, | |||
| pub struct State<B> { | |||
There was a problem hiding this comment.
why not add B: Backend here too?
There was a problem hiding this comment.
That's the same commit as #4632 as this builds upon that, we can ice this until it's in.
arkpar
added
A6-mustntgrumble 💦
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes after #4632
Allows us to execute transactions on incomplete tries without issue.