This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fast in-place migration for adding and removing column families #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
NikVolf
reviewed
Feb 27, 2017
parity/migration.rs
Outdated
| fs::rename(&db_path, &backup_path)?; | ||
| // completely in-place migration leads to the paths being equal. | ||
| // in that case, no need to shuffle directories. | ||
| if temp_path != db_path { |
There was a problem hiding this comment.
to avoid nesting?
if temp_path == db_path { return Ok(()); }
NikVolf
reviewed
Feb 27, 2017
util/src/kvdb.rs
Outdated
| } | ||
| } | ||
|
|
||
| // open 5, remove all. |
There was a problem hiding this comment.
split to separate tests according to F.I.R.S.T ?
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of copying everything over. Now the v10 -> v11 migration is lightning fast, even in debug mode.
@arkpar Touches some of the kvdb code which is a little sensitive. Mind taking a look?
Closes #4681