This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix TxViewer when no to (contract deployment)
#4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A3-inprogress ⏳
tomusdrw
reviewed
Mar 9, 2017
| @@ -256,23 +259,29 @@ export class LocalTransaction extends BaseTransaction { | |||
|
|
|||
| const newTransaction = { | |||
| from: transaction.from, | |||
| to: transaction.to, | |||
There was a problem hiding this comment.
That doesn't seem to be right. What if the transaction actually has valid to?
There was a problem hiding this comment.
Ah, just noticed that we're adding it later on. I don't understand how does it fix the problem though. Previously transaction.to was set to 0x so we will set it anyway, no?
There was a problem hiding this comment.
It's added after :) (L283)
There was a problem hiding this comment.
So the issue was that the to field was set, and thus formatted to hex: '' => '0x'.
I guess the API should be modified in order to take this empty to case into account.
There was a problem hiding this comment.
Yeap. Current fix does the trick, i.e. not encoding it.
ngotchac
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
jacogr
pushed a commit
that referenced
this pull request
Mar 10, 2017
* Added React Hot Reload to dapps + TokenDeplpoy fix * Fixes to the LocalTx dapp * Don't send the nonce for mined transactions * Don't encode empty to values for options
Merged
arkpar
pushed a commit
that referenced
this pull request
Mar 10, 2017
* Added React Hot Reload to dapps + TokenDeplpoy fix (#4846) * Fix method decoding (#4845) * Fix contract deployment method decoding in Signer * Linting * Fix TxViewer when no `to` (contract deployment) (#4847) * Added React Hot Reload to dapps + TokenDeplpoy fix * Fixes to the LocalTx dapp * Don't send the nonce for mined transactions * Don't encode empty to values for options * Pull steps from actual available steps (#4848) * Wait for the value to have changed in the input (#4844) * Backport Regsirty changes from #4589 * Test fixes for #4589
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4799