-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update expanse json with fork at block 600000 #5351
Conversation
It looks like @chrisfranko hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Parity Technologies CLA Bot |
[clabot:check] |
It looks like @chrisfranko signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
"eip161abcTransition": "0x7fffffffffffffff", | ||
"eip161dTransition": "0x7fffffffffffffff" | ||
"eip150Transition": "0x927C0", | ||
"eip155Transition": "0x927C0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With EIP155 enabled, you may want to specify a "chainID" in params. Otherwise, transactions from the Ethereum mainnet will still be replayable onto expanse and vice-versa as they both specify network ID 1, defeating the point a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, chainID
is used only for transaction signing and defaults to the value of networkID
if not specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I get what you are saying, however Expanse uses a completely different network identifier so nodes dont even have the ability to talk to each other and fail at the handshake. I suppose people could copy over a raw tx and try to replay those txs on EXP but its highly unlikely any EXP addresses are also used for ETH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh man I just went full potato, sorry, doing 100 things at once today. Ill choose a chainID and submit it in a few, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rphmeier updated to chainID 2, since etc chose 61.
* Update expanse json with fork at block 600000 * update exp chainID to 2
* v1.6.8 * Update expanse json with fork at block 600000 (#5351) * Update expanse json with fork at block 600000 * update exp chainID to 2 * Bumped mio * Fixed default UI port for mac installer (#5782) * Blacklist empty phrase account. * Update Cid/multihash/ring/tinykeccak (#5785) * Updating ring,multihash,tiny-keccak * Updating CID in ipfs. * Disable compression for RLP strings
We are updating to the latest exp protocol at block 600k