Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update expanse json with fork at block 600000 #5351

Merged
merged 2 commits into from
Apr 3, 2017

Conversation

chrisfranko
Copy link
Contributor

We are updating to the latest exp protocol at block 600k

@parity-cla-bot
Copy link

It looks like @chrisfranko hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@chrisfranko
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @chrisfranko signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 30, 2017
"eip161abcTransition": "0x7fffffffffffffff",
"eip161dTransition": "0x7fffffffffffffff"
"eip150Transition": "0x927C0",
"eip155Transition": "0x927C0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With EIP155 enabled, you may want to specify a "chainID" in params. Otherwise, transactions from the Ethereum mainnet will still be replayable onto expanse and vice-versa as they both specify network ID 1, defeating the point a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, chainID is used only for transaction signing and defaults to the value of networkID if not specified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I get what you are saying, however Expanse uses a completely different network identifier so nodes dont even have the ability to talk to each other and fail at the handshake. I suppose people could copy over a raw tx and try to replay those txs on EXP but its highly unlikely any EXP addresses are also used for ETH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man I just went full potato, sorry, doing 100 things at once today. Ill choose a chainID and submit it in a few, sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rphmeier updated to chainID 2, since etc chose 61.

@gavofyork gavofyork added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 3, 2017
@gavofyork gavofyork merged commit 41700a6 into openethereum:master Apr 3, 2017
@5chdn 5chdn added the B0-patch label May 18, 2017
@5chdn 5chdn mentioned this pull request May 18, 2017
arkpar pushed a commit that referenced this pull request Jun 7, 2017
* Update expanse json with fork at block 600000

* update exp chainID to 2
arkpar added a commit that referenced this pull request Jun 7, 2017
* v1.6.8

* Update expanse json with fork at block 600000 (#5351)

* Update expanse json with fork at block 600000

* update exp chainID to 2

* Bumped mio

* Fixed default UI port for mac installer (#5782)

* Blacklist empty phrase account.

* Update Cid/multihash/ring/tinykeccak (#5785)

* Updating ring,multihash,tiny-keccak

* Updating CID in ipfs.

* Disable compression for RLP strings
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants