Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[beta] Fix ethsign #5600

Merged
merged 4 commits into from
May 18, 2017
Merged

[beta] Fix ethsign #5600

merged 4 commits into from
May 18, 2017

Conversation

tomusdrw
Copy link
Collaborator

Not labelling as A8-backport since the code is completely different.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels May 11, 2017
@tomusdrw tomusdrw requested a review from rphmeier May 11, 2017 15:13
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 11, 2017
@gavofyork
Copy link
Contributor

this is a little problematic. it blindly copies geth, yet:

  • the documentation on the ethereum and parity RPC wiki contains an example which states the original ordering;
  • oo7-parity.js assumes the original ordering;
  • at least one dapp the same.

@tomusdrw
Copy link
Collaborator Author

@gavofyork
Copy link
Contributor

ok the EF changed the wiki spec (unilaterally - how surprising) to fit the geth impl.

https://github.com/ethereum/wiki/wiki/JSON-RPC/_compare/c4321dedf743c6e0d9dd5d3679b028cae46eef7c...3dea1229fb5a23188798075d6127406a1ab70690

may as well play along.

@gavofyork gavofyork added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A8-looksgood 🦄 Pull request is reviewed well. labels May 16, 2017
@tomusdrw
Copy link
Collaborator Author

Seems that build failure is not related to my changes. @paritytech/ci could you guys have a look? kcov is not installed?

remove kcov
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels May 18, 2017
@gavofyork gavofyork merged commit 8dfc10e into beta May 18, 2017
@gavofyork gavofyork deleted the ethsign-beta branch May 18, 2017 12:50
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants