Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Recover from empty phrase in dev mode #5698

Merged
merged 5 commits into from
May 30, 2017
Merged

Recover from empty phrase in dev mode #5698

merged 5 commits into from
May 30, 2017

Conversation

ngotchac
Copy link
Contributor

No description provided.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels May 26, 2017
@gavofyork gavofyork added B0-patch A8-looksgood 🦄 Pull request is reviewed well. A0-pleasereview 🤓 Pull request needs code review. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels May 28, 2017
tomusdrw
tomusdrw suggested changes May 29, 2017
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PropTypes should include both cases.

js/src/views/Signer/components/RequestOrigin/requestOrigin.js Outdated
@@ -29,7 +29,9 @@ export default class RequestOrigin extends Component {
static propTypes = {
origin: PropTypes.shape({
type: PropTypes.oneOf(['unknown', 'dapp', 'rpc', 'ipc', 'signer']),
details: PropTypes.string.isRequired
details: PropTypes.shape({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it can be either string (RPC origin, Dapp id, IPC session) or object with details in it.

@tomusdrw tomusdrw added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 29, 2017
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels May 30, 2017
@gavofyork gavofyork merged commit c2c7231 into master May 30, 2017
@gavofyork gavofyork deleted the ng-recover-dev branch May 30, 2017 17:28
@tomusdrw tomusdrw mentioned this pull request Jun 2, 2017
Closed
@codewiz
Copy link

codewiz commented Jun 2, 2017

I am building from head, but the bug is still present. Could it be that that the parity-ui-precompiled needs to be updated?

jacogr pushed a commit that referenced this pull request Jun 7, 2017
@ngotchac @jacogr
Merge #5698
ae8d00c
@jacogr jacogr mentioned this pull request Jun 7, 2017
Merged
arkpar pushed a commit that referenced this pull request Jun 7, 2017
@jacogr @arkpar
[beta] Backports (#5789)
fb82c6c 
* Merge #5716

* Merge #5784

* Merge #5698
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngotchac @codewiz @tomusdrw @gavofyork