This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Bump mio #5763
Merged
Bump mio #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
NikVolf
reviewed
Jun 5, 2017
| @@ -54,6 +54,9 @@ | |||
| //! } | |||
| //! ``` | |||
|
|
|||
| //TODO: use Poll from mio | |||
| #![allow(deprecated)] | |||
There was a problem hiding this comment.
how about limit this allowance to deprecated mio imports only?
this todo might live for ages there
There was a problem hiding this comment.
Is there a way to do that? Setting an attribute on extern crate mio does not work.
There was a problem hiding this comment.
you have to mark every use::mio::<DeprecatedItem> with this #[allow(deprecated)] I believe
but let me double-check
There was a problem hiding this comment.
Ok, this doesn't work, it supresses only use itself and still warns when actually used
Disregard this remark, then
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashes on windows