This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove public node settings from cli #8758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
niklasad1
approved these changes
Jun 1, 2018
ascjones
reviewed
Jun 1, 2018
parity/run.rs
Outdated
| false => Some(account_provider.clone()) | ||
| }; | ||
|
|
||
| let secret_store = Some(account_provider.clone()); |
There was a problem hiding this comment.
Is it possible now to remove the Option from secret_store in the rpc dependencies? Then could remove these unwraps e.g. https://github.com/paritytech/parity/blob/master/rpc/src/v1/impls/signing_unsafe.rs#L111.
ascjones
approved these changes
Jun 1, 2018
ascjones
added
A7-looksgoodtestsfail 🤖
|
Just some compilation errors in some mocks |
5chdn
added
A8-looksgood 🦄
|
Question: is there anything left from public node after this is merged? |
|
@5chdn This remove all things enabled by the |
dvdplm
added a commit
that referenced
this pull request
Jun 4, 2018
* master: Remove HostTrait altogether (#8681) ethcore-sync: fix connection to peers behind chain fork block (#8710) Remove public node settings from cli (#8758) Custom Error Messages on ENFILE and EMFILE IO Errors (#8744) CI: Fixes for Android Pipeline (#8745) Remove NetworkService::config() (#8653) Fix XOR distance calculation in discovery Kademlia impl (#8589) Print warnings when fetching pending blocks (#8711)
5 tasks
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 4, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: Remove Result wrapper from AccountProvider in RPC impls (openethereum#8763) Update `license header` and `scripts` (openethereum#8666) Remove HostTrait altogether (openethereum#8681) ethcore-sync: fix connection to peers behind chain fork block (openethereum#8710) Remove public node settings from cli (openethereum#8758)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel #8649.
Remove public node related settings. Keep legacy
--public-nodeargs andpublic_nodeitem in config.toml to keep it backward compatible.