Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds stake-tracker pallet and integrates with the staking pallet #1933

Open
wants to merge 162 commits into
base: master
Choose a base branch
from
Open

Adds stake-tracker pallet and integrates with the staking pallet #1933

wants to merge 162 commits into from
+8,609 −2,872

Commits on Oct 18, 2023

  1. Adds stake-tracker pallet and integrates with the staking pallet

    @gpestana
    gpestana committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    5803d69 View commit details
    Browse the repository at this point in the history

  2. Comments and other nit fixes

    @gpestana
    gpestana committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c7ad6bf View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Removes the untracked stake

    @gpestana
    gpestana committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    cb393b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    84a3b71 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    46f5f2e View commit details
    Browse the repository at this point in the history

  2. Removes completely the untracked stake code

    @gpestana
    gpestana committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b9d3f64 View commit details
    Browse the repository at this point in the history

  3. Fixes to review comments

    @gpestana
    gpestana committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b42a160 View commit details
    Browse the repository at this point in the history

  4. more improvements

    @gpestana
    gpestana committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    086a183 View commit details
    Browse the repository at this point in the history

  5. fixes comments

    @gpestana
    gpestana committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    7b89e06 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. nits and more tests

    @gpestana
    gpestana committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ad1c49d View commit details
    Browse the repository at this point in the history

  2. nits and more tests

    @gpestana
    gpestana committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2c2256d View commit details
    Browse the repository at this point in the history

  3. Adds more tests

    @gpestana
    gpestana committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e2babf5 View commit details
    Browse the repository at this point in the history

  4. Adds more testing

    @gpestana
    gpestana committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    cab3568 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. improves testing

    @gpestana
    gpestana committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0152b34 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Change score typ of target list from voteweight to balance

    @gpestana
    gpestana committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ae98ed9 View commit details
    Browse the repository at this point in the history

  2. adds more rebagging and sorting tests to stake-tracker

    @gpestana
    gpestana committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ac4a7af View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. More tests

    @gpestana
    gpestana committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c2d681d View commit details
    Browse the repository at this point in the history

  2. test fixing due to new target list ordering

    @gpestana
    gpestana committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4e06d60 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Adds more staking tests for the stake-tracker integration

    @gpestana
    gpestana committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bbc59a5 View commit details
    Browse the repository at this point in the history

  2. more stake_tracker integration tests

    @gpestana
    gpestana committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    33a9357 View commit details
    Browse the repository at this point in the history

  3. fixes target score updates when kicking

    @gpestana
    gpestana committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    01793c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Addresses review comments; moves stake-tracker into staking crate

    @gpestana
    gpestana committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    fee0514 View commit details
    Browse the repository at this point in the history

  2. Adds more defensives

    @gpestana
    gpestana committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    30a9c47 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. ledger.kill will fail if preconditions have not been met

    @gpestana
    gpestana committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    05c40db View commit details
    Browse the repository at this point in the history

  2. fixes remaining tests

    @gpestana
    gpestana committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    77d7762 View commit details
    Browse the repository at this point in the history

  3. Adds stake-tracker to westend runtime

    @gpestana
    gpestana committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f3e4185 View commit details
    Browse the repository at this point in the history

  4. nits to make CI happy

    @gpestana
    gpestana committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    bd2d7e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Update substrate/frame/staking/src/mock.rs 

    Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
    @gpestana @liamaharon
    gpestana and liamaharon committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ed3cc48 View commit details
    Browse the repository at this point in the history

  2. Update substrate/frame/staking/stake-tracker/src/mock.rs 

    Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
    @gpestana @liamaharon
    gpestana and liamaharon committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    dc141ad View commit details
    Browse the repository at this point in the history

  3. Update substrate/frame/staking/stake-tracker/src/lib.rs 

    Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
    @gpestana @liamaharon
    gpestana and liamaharon committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bbb5740 View commit details
    Browse the repository at this point in the history

  4. Update substrate/frame/staking/stake-tracker/Cargo.toml 

    Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
    @gpestana @liamaharon
    gpestana and liamaharon committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1d98e7d View commit details
    Browse the repository at this point in the history

  5. Adds try-state checks to stake-tracker pallet; review nits

    @gpestana
    gpestana committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    964413c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Removes duplicate assert

    @gpestana
    gpestana committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    25c97e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Refactors staking and stake-tracker so that target and voter lists … 

    …include idle stakers (#2497)

In this PR we change the current assumptions so that `TargetList` and
`VoterList` **also** keep track of the idle stakers (w.g. chilled) and
the target scores are tracked and updated even while the validator is
chilled. The idle stakers will be removed when the ledger unbonds.

This allows the stake-tracker to keep track of the chilled validators
and respective score so that a re-validate of a chilled validator is
brought up with the correct target score (i.e. self stake + all current
nominations in the system).

---------

Co-authored-by: command-bot <>
    @gpestana
    gpestana committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    f9c439c View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Addresses review comments

    @gpestana
    gpestana committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b09f8bc View commit details
    Browse the repository at this point in the history

  2. review comments

    @gpestana
    gpestana committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    062868d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    992cff1 View commit details
    Browse the repository at this point in the history

  4. ".git/.scripts/commands/fmt/fmt.sh"

    command-bot committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    70ab8c3 View commit details
    Browse the repository at this point in the history

  5. Update documentation

    @gpestana
    gpestana committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ee52b6f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Wraps slash tests on TestExternalities

    @gpestana
    gpestana committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a3b0b41 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Removes ability to explicitly add moot nominations, as it fails with … 

    …BadTarget
    @gpestana
    gpestana committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f1526e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. Keeps approvals even if the validator chills or stash is killed (if t… 

    …here are nominations)

m
    @gpestana
    gpestana committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    2870db3 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Update docs; VoterList node is removed upon chilling.

    @gpestana
    gpestana committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    6713df3 View commit details
    Browse the repository at this point in the history

  2. Update substrate/frame/staking/stake-tracker/src/lib.rs 

    Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
    @gpestana @liamaharon
    gpestana and liamaharon committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    341e28e View commit details
    Browse the repository at this point in the history

  3. review nits

    @gpestana
    gpestana committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    dba853b View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Refactor OnStakingUpdate interface to be safer to use. (#2877) 

    Co-authored-by: command-bot <>
    @gpestana
    gpestana committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b316f6f View commit details
    Browse the repository at this point in the history

  2. Fixes fast-unstake test setup

    @gpestana
    gpestana committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    261456e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    27a85fc View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    088783e View commit details
    Browse the repository at this point in the history

  2. simplifies do_add_validator

    @gpestana
    gpestana committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    bf1e043 View commit details
    Browse the repository at this point in the history

  3. Adds prdoc

    @gpestana
    gpestana committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    c0497b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. fixes clippy

    @gpestana
    gpestana committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    27129fb View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Fixes clippy

    @gpestana
    gpestana committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f0098d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    fa94b7f View commit details
    Browse the repository at this point in the history

  2. after master merge fixes

    @gpestana
    gpestana committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f89a046 View commit details
    Browse the repository at this point in the history

  3. simplify on_remove_* logic

    @gpestana
    gpestana committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    18f11b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Adds stake-tracker to benchmarking runtime

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0e95378 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ff8a64e View commit details
    Browse the repository at this point in the history

  3. stake-tracker cargo fix

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    261e8ab View commit details
    Browse the repository at this point in the history

  4. Fixes stake-tracker/no-std

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    63f43f8 View commit details
    Browse the repository at this point in the history

  5. Fixes feature dependencies

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    bc2f2ce View commit details
    Browse the repository at this point in the history

  6. fmt cargo.toml

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    50ea3d0 View commit details
    Browse the repository at this point in the history

  7. fixes westend/stake-tracker runtime config

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    38e6616 View commit details
    Browse the repository at this point in the history

  8. impls max_exposure_page_size for mock (runtime-benchmarks)

    @gpestana
    gpestana committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    5a5494a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. fixes rust docs

    @gpestana
    gpestana committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    246c49a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Adds throughout try-state checks and includes stake-tracker try-state… 

    … checks in the staking pallet tests
    @gpestana
    gpestana committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    41a00a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Update substrate/frame/staking/src/ledger.rs 

    Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
    @gpestana @liamaharon
    gpestana and liamaharon committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3ae6d11 View commit details
    Browse the repository at this point in the history

  2. fixes clippy

    @gpestana
    gpestana committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    cf047db View commit details
    Browse the repository at this point in the history

  3. clean up try-state code

    @gpestana
    gpestana committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6e5d019 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d12cdc2 View commit details
    Browse the repository at this point in the history

  5. clippy nits

    @gpestana
    gpestana committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a1b16c7 View commit details
    Browse the repository at this point in the history

  6. Add try-runtime gated method in sorted list provider to help with checks

    @gpestana
    gpestana committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f48c7de View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Adds the callable drop_dangling_nomination to allow permissionless dr… 

    …opping dangling nominations
    @gpestana
    gpestana committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4ac7fcf View commit details
    Browse the repository at this point in the history

  2. clippy

    @gpestana
    gpestana committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2fdb673 View commit details
    Browse the repository at this point in the history

  3. doc fixes

    @gpestana
    gpestana committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e5ca233 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. simplifies staking imbalance calculation; addresses reviews

    @gpestana
    gpestana committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    786dbf5 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Update substrate/frame/staking/stake-tracker/src/lib.rs 

    Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com>
    @gpestana @georgepisaltu
    gpestana and georgepisaltu committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    bfa02dc View commit details
    Browse the repository at this point in the history

  2. addresses PR comments & simplifies stake-tracker code

    @gpestana
    gpestana committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    44f44ef View commit details
    Browse the repository at this point in the history

  3. add a couple more checks to try-state when building the approvals map

    @gpestana
    gpestana committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ff8ee33 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. ensures OnStakingUpdate events are triggered at the correct places an… 

    …d tests
    @gpestana
    gpestana committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    740565b View commit details
    Browse the repository at this point in the history

  2. updates comments; ensures that voter list is also always sorted + tes… 

    …ts; PR reviews
    @gpestana
    gpestana committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8c8d004 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d48f823 View commit details
    Browse the repository at this point in the history

  2. nits and address comments

    @gpestana
    gpestana committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    639edaf View commit details
    Browse the repository at this point in the history

  3. defensive instead of err in case of killing a stash that is not Idle

    @gpestana
    gpestana committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9af1122 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Adds stake-tracker benchs

    @gpestana
    gpestana committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7dd813b View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9ec7759 View commit details
    Browse the repository at this point in the history

  2. Removes the need for staking to check the state of the target and vot… 

    …er list
    @gpestana
    gpestana committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ab802b5 View commit details
    Browse the repository at this point in the history

  3. cargo-clippy fix

    @gpestana
    gpestana committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    12fce24 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d44f734 View commit details
    Browse the repository at this point in the history

  2. Update substrate/frame/staking/stake-tracker/src/lib.rs 

    Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
    @gpestana @kianenigma
    gpestana and kianenigma committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    afeddd2 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e66d00f View commit details
    Browse the repository at this point in the history

  2. starts adding mmb for target list

    @gpestana
    gpestana committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    56ecb62 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. moves drop_dangling_target extrinsic from stake-tracker to staking

    @gpestana
    gpestana committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    595022e View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. finishes dangling nomination benchs

    @gpestana
    gpestana committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    fa7edf1 View commit details
    Browse the repository at this point in the history

  2. fixes BadTarget error in benchmarks

    @gpestana
    gpestana committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    b4f9e90 View commit details
    Browse the repository at this point in the history

  3. Adds v13 mmb migration benchmarks and tests

    @gpestana
    gpestana committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    803f148 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. refactors benchmarks to use benchmarking::v2

    @gpestana
    gpestana committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6123e12 View commit details
    Browse the repository at this point in the history

  2. some refactoring on mmb benchmarks

    @gpestana
    gpestana committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    25589af View commit details
    Browse the repository at this point in the history

  3. changes mmb strategy -- do nominator-based migrations instead of vali… 

    …dator
    @gpestana
    gpestana committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7e6db9e View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Finishes benchmarks and MMB for stake-tracker

    @gpestana
    gpestana committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2864631 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. simplifies defensive for tests only

    @gpestana
    gpestana committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b01f013 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ac5df15 View commit details
    Browse the repository at this point in the history

  3. nit

    @gpestana
    gpestana committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    34c4612 View commit details
    Browse the repository at this point in the history

  4. nits

    @gpestana
    gpestana committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6273d4c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. fixes imports

    @gpestana
    gpestana committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2096b25 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i… 

    …nto HEAD
    command-bot committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1080cc4 View commit details
    Browse the repository at this point in the history

  3. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime… 

    …=dev --target_dir=substrate --pallet=pallet_staking
    command-bot committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c6593dc View commit details
    Browse the repository at this point in the history

  4. starts sorting mode

    @gpestana
    gpestana committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    605e54d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. fixes iter

    @gpestana
    gpestana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3fa1601 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9d335ca View commit details
    Browse the repository at this point in the history

  2. cargo lock update after merging master

    @gpestana
    gpestana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9e18a84 View commit details
    Browse the repository at this point in the history

  3. Update substrate/frame/staking/stake-tracker/src/lib.rs 

    Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
    @gpestana @kianenigma
    gpestana and kianenigma committed May 2, 2024
    Configuration menu
    Copy the full SHA
    40620e0 View commit details
    Browse the repository at this point in the history

  4. Update substrate/frame/staking/stake-tracker/src/mock.rs 

    Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
    @gpestana @kianenigma
    gpestana and kianenigma committed May 2, 2024
    Configuration menu
    Copy the full SHA
    97d254e View commit details
    Browse the repository at this point in the history

  5. nit

    @gpestana
    gpestana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8624320 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6e452e1 View commit details
    Browse the repository at this point in the history

  7. nits

    @gpestana
    gpestana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e9218b6 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1dd4d38 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. stake-tracker feedback PR (#4411) 

    - Changes the target list score type from balance to `u128`
(`ExtendedBalance`)
  - simplifies `balance/ vote_weight/ extended_balance` conversions
  - relies less on the currency total issuance call
  - ensures approval stake calculations/storage is safe 
- Simplifies stake tracker logic
  - removes a few redundant checks
  - split `on_stake_update` code
- Ensures `VoterUpdateMode` is taken into consideration in try-state
checks
  - use voter mode lazy in benchmarks
  - update weights + check the diff with voter lazy 
- Docs improvements
- All tests passing after merging validator disabling and virtual
stakers

**new**
- ensures duplicate nominations are dedup before calculating the
approvals stake
- chills nominator after total slash to ensure the target can be
reaped/kill without leaving nominations behind.
- ensures that switching from validator to nominator and back is correct
- a nominator may have an entry in the targetlist (if it was a validator
+ has nominations)
  - ensure target node is removed if balance is 0 and it is a nominator.
- addresses
paritytech-secops/srlabs_findings#383

---
**Other experiments:** (not included)
- #4402 (passing the
status of the staker with who in the OnStakingUpdate interface is less
clean, it turns out)
- #4361

---------

Co-authored-by: command-bot <>
    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    628bceb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gpestana/stake-tracker_integration' of github.com:parit… 

    …ytech/polkadot-sdk into gpestana/stake-tracker_integration
    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    52cde8a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c444174 View commit details
    Browse the repository at this point in the history

  4. fixes zepter

    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d726d0f View commit details
    Browse the repository at this point in the history

  5. ensures mmb bench checks are deteministic

    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3d4452f View commit details
    Browse the repository at this point in the history

  6. clippy nits

    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d225176 View commit details
    Browse the repository at this point in the history

  7. taplo nit fixes

    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a56f765 View commit details
    Browse the repository at this point in the history

  8. clippy nit

    @gpestana
    gpestana committed May 10, 2024
    Configuration menu
    Copy the full SHA
    80895ad View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Stake tracker improvements (migration and try-state checks OK in Polk… 

    …adot) (#4673)

Changes in the migration code introduced in this PR:
- Migration removes duplicate nominations in all nominators, if they
exist (changes by calling `fn do_add_nominator` with dedup nominations)
- Migration removes all the non active validator nominations to avoid
adding dangling nominations (changes by calling `fn do_add_nominator` if
necessary)
- Migration iterates through all `Nominators` map first and through all
the `Validators` map to insert all the validators that are not nominated
to the target list (with self-stake only).
- Moves stake-tracker related try-state checks to the staking pallet (no
try-state checks in the stake-tracker pallet anymore).
- Runs benchmarks for MMB migration step with bench bot. 

The migration code has been validated against the Polkadot using the
externalities tests in
[polkadot/runtime/westend/src/lib.rs](https://github.com/paritytech/polkadot-sdk/pull/4436/files/46a80f14ba8990b014d8f9df36727c77e2f3e929#diff-5264d812f7aadfc486efffd3322b11c8dee5e8ddf2e77e0a9e70b573f3d2afdd).
Upon running the migrations, we ensure that:
- All validators have been added to the target list with their correct
approvals score (as per the try-state checks).
- All nominations are "cleaned" (see def. of clean above)
- Try-state checks related to stake-tracker and approvals pass.

Note: Same as #4436 but
with a non-messed up git history. Merging into
`gpestana/stake-tracker_integration`.

---------

Co-authored-by: Ankan <ankan.anurag@gmail.com>
Co-authored-by: command-bot <>
    @gpestana @Ank4n
    gpestana and Ank4n committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6219b32 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    822a945 View commit details
    Browse the repository at this point in the history

  3. fixes umbrella runtime and stake-tracker mock after master merge

    @gpestana
    gpestana committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1aa1c80 View commit details
    Browse the repository at this point in the history

  4. nits

    @gpestana
    gpestana committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4bf868a View commit details
    Browse the repository at this point in the history

  5. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime… 

    …=westend --target_dir=polkadot --pallet=pallet_staking
    command-bot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3a07d09 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. docs pass

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1445118 View commit details
    Browse the repository at this point in the history

  2. nit: fix umbrella cargo lint

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e785621 View commit details
    Browse the repository at this point in the history

  3. fixes nomination pools benchmarks (validators must exist)

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8c685d7 View commit details
    Browse the repository at this point in the history

  4. adds try-state checks to ensure no duplicate targets in nomination

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c34ede1 View commit details
    Browse the repository at this point in the history

  5. fixes tests and mocks in other pallets

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    303b4be View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    66290a6 View commit details
    Browse the repository at this point in the history

  7. semver nits

    @gpestana
    gpestana committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cc16579 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. all try-state checks pass for ext pallets; prdoc nits

    @gpestana
    gpestana committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fc39f8e View commit details
    Browse the repository at this point in the history

  2. nit

    @gpestana
    gpestana committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f2613de View commit details
    Browse the repository at this point in the history

  3. on_add_validator without option

    @gpestana
    gpestana committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8caac45 View commit details
    Browse the repository at this point in the history

  4. doc improvements; drop dangling target fix; more tests

    @gpestana
    gpestana committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b44a4e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3a68c14 View commit details
    Browse the repository at this point in the history

  2. addresses review

    @gpestana
    gpestana committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    66f8259 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. simplifies dedup

    @gpestana
    gpestana committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ea9e838 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4c79d3b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b3bd4fd View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. compilation nits after merge; addresses review comments.

    @gpestana
    gpestana committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0fda93d View commit details
    Browse the repository at this point in the history

  2. removes unecessary staking::status calls in stake-tracker

    @gpestana
    gpestana committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    62a3e5c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d08cf70 View commit details
    Browse the repository at this point in the history

  4. merge nits: removes sp_std

    @gpestana
    gpestana committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    19abad8 View commit details
    Browse the repository at this point in the history

  5. fixes dependencies on mmbs without sp_std

    @gpestana
    gpestana committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cb631fa View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9219e2e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. use crv2 in stake-tracker mock

    @gpestana
    gpestana committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f591b89 View commit details
    Browse the repository at this point in the history

  2. Improves MMB docs and naming

    @gpestana
    gpestana committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8b0dec2 View commit details
    Browse the repository at this point in the history

  3. stake-tracker cargo toml to use workspace

    @gpestana
    gpestana committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a0d3962 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4f90672 View commit details
    Browse the repository at this point in the history

  5. ".git/.scripts/commands/fmt/fmt.sh"

    command-bot committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4ddff0f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. nit to prevent defensives in migration

    @gpestana
    gpestana committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    aab02ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gpestana/stake-tracker_integration' of github.com:parit… 

    …ytech/polkadot-sdk into gpestana/stake-tracker_integration
    @gpestana
    gpestana committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    06b6821 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Adds target approvals buffering below a threshold (#5168) 

    This PR adds target stake updates buffering to `stake-tracker`. It
exposes a configuration that defines a threshold below which the target
score *should not* be updated automatically in the target list. The
`Config::ScoreStrictUpdateThreshold` defines said threshold. If a target
stake update is below the threshold, the stake update is buffered in the
`UnsettledTargetScore` storage map while the target list is not
affected. Multiple approvals updates can be buffered for the same
target. Calling `Call::settle` will setttle the buffered approvals tally
for a given target. Setting `Config::ScoreStrictUpdateThreshold` to
`None` disables the stake approvals buffering.

- [x] benchmarks
- [x] `try-state` checks considering the unsettled score
- [x] docs

---------

Co-authored-by: command-bot <>
    @gpestana
    gpestana committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    933e159 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Revert "Adds target approvals buffering below a threshold" (#5235) 

    Reverts #5168 as per
#5168 (comment)
    @gpestana
    gpestana committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    24c4faa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gpestana/stake-tracker_integration

    @gpestana
    gpestana committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1b6d567 View commit details
    Browse the repository at this point in the history